RFR 8184961: jdk.test.lib.util.FileUtils.deleteFileWithRetry0 should wait for absence of a file

Andrey Nazarov andrey.x.nazarov at oracle.com
Wed Jul 26 19:45:23 UTC 2017


> On 26 Jul 2017, at 12:31, Chris Hegarty <chris.hegarty at oracle.com> wrote:
> 
> 
>> On 26 Jul 2017, at 18:03, Hohensee, Paul <hohensee at amazon.com> wrote:
>> 
>> A double negative (!Files.notExists) somewhat unusual coding and will perplex people reading it. They might even switch it back to Files.exists as a style cleanup, so I recommend adding a comment explaining why you’re using it.
> 
> As the original author of this code, +1000
Code has been pushed. I’ll create new issue for that :)

—Andrei
> 
> -Chris.
> 
> 
>> Thanks,
>> 
>> Paul
>> 
>> On 7/25/17, 5:08 PM, "core-libs-dev on behalf of Andrey Nazarov" <core-libs-dev-bounces at openjdk.java.net on behalf of andrey.x.nazarov at oracle.com> wrote:
>> 
>>   Thanks, Brian
>> 
>>   —Andrei
>>> On 25 Jul 2017, at 16:41, Brian Burkhalter <brian.burkhalter at oracle.com> wrote:
>>> 
>>> Hi Andrei,
>>> 
>>> I think this looks good.
>>> 
>>> Thanks,
>>> 
>>> Brian
>>> 
>>>> On Jul 25, 2017, at 3:59 PM, Andrey Nazarov <andrey.x.nazarov at oracle.com> wrote:
>>>> 
>>>> Can anyone look?
>>>> 
>>>> —Thanks,
>>>> Andrei
>>>>> On 19 Jul 2017, at 18:21, Andrey Nazarov <andrey.x.nazarov at oracle.com> wrote:
>>>>> 
>>>>> Hi,
>>>>> 
>>>>> Could you review fix in test library which should help to resolve intermittent issues on Windows machines during directories clean up. 
>>>>> 
>>>>> Bug: https://bugs.openjdk.java.net/browse/JDK-8184961 <https://bugs.openjdk.java.net/browse/JDK-8184961>
>>>>> Review: http://cr.openjdk.java.net/~anazarov/JDK-8184961/webrev.00/webrev/
>>>>> 
>>>>> 
>>>>> —Andrei
>>> 
>> 
>> 
>> 
> 



More information about the core-libs-dev mailing list