[10] RFR: 8184940: JDK 9 rejects zip files where the modified day or month is 0
Martin Buchholz
martinrb at google.com
Fri Jul 28 22:30:43 UTC 2017
I took another look.
90 if ((dtime >> 25) == 0) {
It looks like this will test only the year, not all the date fields.
Shouldn't that be s/25/16/ ?
Does this code handle the "true" epoch of 1980-01-01 ?
On Thu, Jul 27, 2017 at 11:54 AM, Liam Miller-Cushon <cushon at google.com>
wrote:
> On Wed, Jul 26, 2017 at 4:12 PM, Martin Buchholz <martinrb at google.com>
> wrote:
>
>> I wonder where the "8" in the "Friday the 30th" date comes from. Could
>> your California time zone be leaking into the test? The DOS timestamp is
>> interpreted as local time while Instant.parse uses UTC? Will the test
>> still pass if you run jtreg under TZ=EST?
>>
>
> Thanks, fixed:
> http://cr.openjdk.java.net/~cushon/8184940/webrev.01/
>
More information about the core-libs-dev
mailing list