JDK 10 RFR of JDK-8181126: Refactor shell test java/nio/Buffer/LimitDirectMemory.sh to java

[Amy Lu]

Thank you all for reviewing.

Pushed with minor update as Roger suggested.

Thanks,
Amy

On 5/31/17 5:11 AM, Roger Riggs wrote:
> Hi Amy,
>
> LimitDirectMemory.java: 61  - Can you add a usage message to the 
> exception identifying the arguments.
>  It is good practice to provide a message so when reading a failing 
> log, you don't have to go back to the source and stack trace.
>
> LimitDirectMemoryNegativeTest.java:
>
> 45:  Add a usage message to the exception like:  "missing size argument"
>  it will help someone who later tries to run it from the command line
>
> 51 - the test should check that the error message includes the
>   offending argument;  append the arg[0] to ERR.
>
>         .shouldContain(ERR*+ arg[0]*)
>
> Looks fine, no need for another review.
>
> Thanks, Roger
>
>
> On 5/26/2017 8:29 PM, Brent Christian wrote:
>> That all looks fine to me, Amy.
>>
>> (You'll also need a JDK 10 Reviewer).
>>
>> Thanks,
>> -Brent
>>
>> On 5/25/17 7:42 PM, Amy Lu wrote:
>>> java/nio/Buffer/LimitDirectMemory.sh
>>>
>>> Please review this patch to refactor the shell test to java.
>>>
>>> bug: https://bugs.openjdk.java.net/browse/JDK-8181126
>>> webrev: http://cr.openjdk.java.net/~amlu/8181126/webrev.00/
>>>
>>> Thanks,
>>> Amy
>