JDK 10 RFR of JDK-8181393: Refactor shell test Selector/lots_of_updates.sh and SocketChannel/Open.sh to java

[Paul Sandoz]

> On 31 May 2017, at 23:45, Amy Lu <amy.lu at oracle.com> wrote:
> 
> java/nio/channels/Selector/lots_of_updates.sh
> java/nio/channels/SocketChannel/Open.java which runs shell test:
>     * @run shell Open.sh
> 
> Please review this patch to refactor above shell tests to java.
> 
> bug: https://bugs.openjdk.java.net/browse/JDK-8181393
> webrev: http://cr.openjdk.java.net/~amlu/8181393/webrev.00/
> 

+1

Out of curiosity is jtreg compilation of a test smart enough to know of at least some of its dependencies.

  24 /*
  25  * @test
  26  * @bug 6824477
  27  * @summary Selector.select can fail with IOException "Invalid argument" on
  28  *     Solaris if maximum number of file descriptors is less than 10000
  29  * @requires (os.family != "windows")
  30  * @library /test/lib
  31  * @build LotsOfUpdates
  32  * @run main LotsOfUpdatesTest
  33  */
  34
  35 import jdk.test.lib.process.ProcessTools;
  36
  37 public class LotsOfUpdatesTest {
Do you require line 31 since LotsOfUpdatesTest refers directly to LotsOfUpdates?

Paul.