(10) RFR of JDK-8180927: refactor ./java/io/Serializable/class/run.sh to java test
Hamlin Li
huaming.li at oracle.com
Tue Jun 6 02:04:38 UTC 2017
Hi Paul,
Thank you for review. Modified as you suggested, it makes the test more
simple. The code was pushed.
Thank you
-Hamlin
On 2017/6/6 6:41, Paul Sandoz wrote:
> I eyeballed quickly and it looks ok.
>
> NonSerializableTest
> --
> 59 return new String[][][] {
> 60 // Write NonSerial1, Read NonSerial1
> 61 new String[][] {new String[] {"NonSerialA_1", "-cp", ".", "TestEntry", "-s", "A"}},
> 62 new String[][] {new String[] {"NonSerialA_1", "-cp", ".", "TestEntry", "-d"}},
>
> You don’t need declare the allocations within array initializer blocks.
>
> Paul.
>
>> On 4 Jun 2017, at 18:37, Hamlin Li <huaming.li at oracle.com> wrote:
>>
>> Ping.
>>
>> Thank you
>>
>> -Hamlin
>>
>>
>> On 2017/6/1 16:22, Hamlin Li wrote:
>>> Would you please review the below patch?
>>>
>>> bug: https://bugs.openjdk.java.net/browse/JDK-8180927
>>>
>>> webrev: http://cr.openjdk.java.net/~mli/8180927/webrev.00/
>>>
>>> Thank you
>>>
>>> -Hamlin
>>>
More information about the core-libs-dev
mailing list