RFR 8181080/10, Refactor several sun/net shell tests to plain java tests
Alan Bateman
Alan.Bateman at oracle.com
Tue Jun 6 15:40:57 UTC 2017
On 06/06/2017 16:28, Felix Yang wrote:
> All 3 tests will fail with error missing java.compiler module.
> I also attempted with --limit-modules=java.se. Then other resources
> will fail with "java.lang.RuntimeException: Need to run with
> --limit-modules java.base". vmoptions will be added to @run entry by
> jtreg, then lead the confusion.
>
> SO IMO, the first proposal to fork a java process with constant
> arguments is probably better than using @run entry.
> http://cr.openjdk.java.net/~xiaofeya/8181080/webrev.00/test/sun/net/www/protocol/jrt/OtherResourcesTest.java.html
>
>
> Do you agree?
It's probably okay but would be nicer if OtherResourcesTest used
executeTestJava (it doesn't need to use JDKToolFinder or executeCommand).
-Alan
More information about the core-libs-dev
mailing list