[10] RFR: 8181586: DateTimeTextProvider.getInstance() returns a new instance every time
Roger Riggs
Roger.Riggs at Oracle.com
Tue Jun 6 16:35:34 UTC 2017
Hi Naoto,
Can you check if the constructor can be made package private. (line 115)
It seems odd to have a singleton but not have the constructor private.
Otherwise looks fine,
Roger
On 6/6/2017 12:25 PM, Naoto Sato wrote:
> Hello,
>
> Please review the fix to the following issue:
>
> https://bugs.openjdk.java.net/browse/JDK-8181586
>
> The proposed changeset is located at:
>
> http://cr.openjdk.java.net/~naoto/8181586/webrev.00/
>
> As suggested in the bug report, the factory method is now returning
> the singleton instance.
>
> Naoto
More information about the core-libs-dev
mailing list