RFR 8181080/10, Refactor several sun/net shell tests to plain java tests

Felix Yang felix.yang at oracle.com
Wed Jun 7 07:04:09 UTC 2017


Hi Alan,

     updated patch. Keep the first version of OtherResourcesTest with 
clean-up.

http://cr.openjdk.java.net/~xiaofeya/8181080/webrev.02/

Thanks,
Felix
On 2017/6/7 0:36, Alan Bateman wrote:
> On 06/06/2017 16:54, Felix Yang wrote:
>> Well, probably no. executeTestJava will add test vm opts to the exec 
>> commands, so it will show two "--limit-modules xxx" either. This is 
>> not the test intended.
> Ah okay, I did write the original test but forget that executeTestJava 
> inherits the options.
>
> Okay, if we can clean up OtherResourcesTest then I'll go along with 
> that approach. By clean-up then it would be nice to move the test 
> description to the top and also reformat the the use of executeCommand 
> so that it's easy to read.
>
> -Alan.



More information about the core-libs-dev mailing list