RFR(M) : 8181761: add explicit @build actions for jdk.test.lib classes in all :tier2 tests

Chris Hegarty chris.hegarty at oracle.com
Thu Jun 8 10:11:11 UTC 2017


Igor,

> On 8 Jun 2017, at 08:20, Igor Ignatyev <igor.ignatyev at oracle.com> wrote:
> 
> http://cr.openjdk.java.net/~iignatyev//8181761/webrev.00/index.html
>> 432 lines changed: 404 ins; 1 del; 27 mod;
> 
> Hi all,
> 
> could you please review this changeset which adds explicit @build actions to tier2 jdk tests? other tests will be updated by the corresponding sub-tasks of 8181758[1].
> 
> webrev: http://cr.openjdk.java.net/~iignatyev//8181761/webrev.00/index.html


Just quickly looking at some of the networking test, e.g. JoinLeave:

  * @bug 4091811 4148753 4102731
  * @summary Test java.net.MulticastSocket joinGroup and leaveGroup
  * @library /test/lib
+ * @build jdk.test.lib.NetworkConfiguration
+ *        jdk.test.lib.Utils
+ *        jdk.test.lib.Asserts
+ *        jdk.test.lib.JDKToolFinder
+ *        jdk.test.lib.JDKToolLauncher
+ *        jdk.test.lib.Platform
+ *        jdk.test.lib.process.*
  * @run main JoinLeave
  */

I believe this test only requires jdk.test.lib.NetworkConfiguration. Is there any
reason why the additional build targets are being added?

-Chris.


More information about the core-libs-dev mailing list