RFR(M) : 8181761: add explicit @build actions for jdk.test.lib classes in all :tier2 tests

Chris Hegarty chris.hegarty at oracle.com
Fri Jun 9 10:46:05 UTC 2017



On 09/06/17 07:42, Igor Ignatyev wrote:
> here is the refreshed version of patch : http://cr.openjdk.java.net/~iignatyev//8181761/webrev.02/index.html <http://cr.openjdk.java.net/~iignatyev//8181761/webrev.02/index.html>

I get 404 Not Found on many links, e.g.
 
http://cr.openjdk.java.net/~iignatyev//8181761/webrev.02/test/java/nio/channels/DatagramChannel/Promiscuous.java.sdiff.html

I think test/java/net/NetworkConfigurationProbe.java is incorrect:

    * @library /test/lib
+  * @build jdk.test.lib.NetworkConfiguration
+  *        jdk.test.lib.Utils
+  *        jdk.test.lib.Asserts
+  *        jdk.test.lib.JDKToolFinder
+  *        jdk.test.lib.JDKToolLauncher
+  *        jdk.test.lib.Platform
+  *        jdk.test.lib.process.*
    * @run main NetworkConfigurationProbe
    */

Should only require jdk.test.lib.NetworkConfiguration & 
jdk.test.lib.Platform, no ?

-Chris.


More information about the core-libs-dev mailing list