[8u-dev] RFR (JAXWS): 8172297: In java 8, the marshalling with JAX-WS does not escape carriage return

[Aleks Efimov]

Thank you for the review Roman.

Can I, please, ask for JDK8u reviewer to go through these changes?

With Best Regards,
Aleksei

On 06/09/2017 04:20 PM, Roman Grigoriadi wrote:
> Looks good to me.
>
> Just a side note that escape handler can be overridden by "setting com.sun.xml.bind.characterEscapeHandler" or “com.sun.xml.bind.marshaller.CharacterEscapeHandler" properties on Marshaller. This is respected by XMLStreamWriterOutput escape handling.
>
>
> Roman
>
>> On 9 Jun 2017, at 16:10, Aleks Efimov <aleksej.efimov at oracle.com> wrote:
>>
>> Hello,
>>
>> Please, help to review the fix that helps JAXWS marshaller to properly escape new-line and carriage return symbols in webservice string parameters:
>> http://cr.openjdk.java.net/~aefimov/8172297/8/00
>>
>> The source part of this fix is a partial backport of JAXWS-RI sync changes that addressed this issue in jaxb-ri project [1].
>> The sync changes are currently under review here:
>> http://mail.openjdk.java.net/pipermail/core-libs-dev/2017-May/047426.html
>>
>> New regression test was added for this issue and it is passing with other JAXWS regression and JCK8 related tests.
>>
>> With Best Regards,
>> Aleksei
>>
>> [1] JAXB-RI related commits:
>> https://github.com/javaee/jaxb-v2/commit/8cbd5e0ec41c94d743c6ae993289e7a18d00aed4
>> https://github.com/javaee/jaxb-v2/commit/2358bcf5ec96e0285e305647887d65adad6ee892
>> https://github.com/javaee/jaxb-v2/commit/eeb5c5631a0a9311c52b23cc20344e6b342cd42a
>>
>>
>>
>>
>>