RFR(S) : 8182565 : remove jdk.testlibrary.Utils::tryFindJvmPid and waitForJvmPid methods
Igor Ignatyev
igor.ignatyev at oracle.com
Wed Jun 21 18:34:25 UTC 2017
Hi Roger,
these two methods block me from incremental removing of jdk.testlibrary, they create a dependency b/w Utils and JDKToolLauncher and ProcessTools, OutputAnalyzer classes and the classes they depend on.
Thanks,
-- Igor
> On Jun 20, 2017, at 12:03 PM, Roger Riggs <Roger.Riggs at Oracle.com> wrote:
>
> Hi Igor,
>
> No particular objection to removing these.
>
> It would be less overhead to change the tests that use this jdk.testlibrary.Utils to use the
> top level utils and then just remove the whole file. Whittling away at these will create a lot of
> intermediate webrevs.
>
> Roger
>
>
> On 6/19/17 7:47 PM, Igor Ignatyev wrote:
>> http://cr.openjdk.java.net/~iignatyev//8182565/webrev.00/index.html
>>> 57 lines changed: 0 ins; 57 del; 0 mod;
>> Hi all,
>>
>> could you please review this small patch which removes two unused methods from jdk.testlibrary.Utils class?
>>
>> webrev: http://cr.openjdk.java.net/~iignatyev//8182565/webrev.00/index.html
>> jbs: https://bugs.openjdk.java.net/browse/JDK-8182565
>> testing: grep -l -e tryFindJvmPid -e waitForJvmPid ./test
>>
>> Thanks,
>> -- Igor
>
More information about the core-libs-dev
mailing list