RFR(M) : 8182154 : merge jdk.testlibrary.Platform and jdk.test.lib.Platform

Igor Ignatyev igor.ignatyev at oracle.com
Tue Jun 27 15:27:13 UTC 2017


Hi Peter,

thank you for your review.

regarding jdk10.patch, I've noticed that a patch file is empty if webrev is used in forest mode (-f). I haven't looked at it any deeper and haven't filed a bug against webrev tool yet.

-- Igor
 
> On Jun 27, 2017, at 12:54 AM, Peter Levart <peter.levart at gmail.com> wrote:
> 
> Hi Igor,
> 
> On 06/27/2017 03:17 AM, Igor Ignatyev wrote:
>> http://cr.openjdk.java.net/~iignatyev/8182154/webrev.01/
>>> 281 lines changed: 18 ins; 223 del; 40 mod;
>> Hi all,
>> 
>> could you please review this changeset which removes Platform from jdk testlibrary and updates tests to use jdk.test.lib.Platform from top level testlibrary instead?
>> as a part of this patch, I've also cleaned up jdk.test.lib.Platform a bit.
>> 
>> testing: all changed tests locally, jdk/test/:tier[1-3]
>> webrev: http://cr.openjdk.java.net/~iignatyev/8182154/webrev.01/
>> jbs: https://bugs.openjdk.java.net/browse/JDK-8182154
>> 
>> Thanks,
>> -- Igor
> 
> The diffs seem look good, but I don't know why I can't download the jdk10.patch file at:
> 
> http://cr.openjdk.java.net/~iignatyev/8182154/webrev.01/jdk10.patch
> 
> It seems to be empty. Could you look at it?
> 
> Regards, Peter
> 



More information about the core-libs-dev mailing list