RFR 10 8183019: Diagnostics for onExitTest

[Langer, Christoph]

Hi Roger,

the change looks good overall.

One thing that I probably don't fully understand:

Line 265: while (blines.isEmpty() && A_alive == A.isAlive()) {

Isn't this a bit dangerous for the case that A isn't alive any more, also wasn't at the time A_alive was initialized and blines is empty for some reason? Then you will end up with an endless loop. But maybe this is a bit theoretical...

Best regards
Christoph



> -----Original Message-----
> From: core-libs-dev [mailto:core-libs-dev-bounces at openjdk.java.net] On
> Behalf Of Roger Riggs
> Sent: Donnerstag, 29. Juni 2017 19:15
> To: Core-Libs-Dev <core-libs-dev at openjdk.java.net>
> Subject: RFR 10 8183019: Diagnostics for onExitTest
> 
> Please review adding diagnostics for java.lang.ProcessHandle.OnExitTest
> [1];
> on Solaris it intermittently detects a process is alive when it should
> be dead.
> So far, I have not been able to reproduce it.
> Also, removes unnecessary test tags.
> 
> Webrev:
>    http://cr.openjdk.java.net/~rriggs/webrev-onexit-8183019/
> 
> Thanks, Roger
> 
> [1] https://bugs.openjdk.java.net/browse/JDK-8177932
>