RFR (JAXP) 8175830: Provide javadoc description for jdk.xml.dom module

Lance Andersen lance.andersen at oracle.com
Tue Mar 7 18:59:10 UTC 2017


I think you are good to go Joe

> On Mar 7, 2017, at 1:56 PM, huizhe wang <huizhe.wang at oracle.com> wrote:
> 
> Thanks Lance.  Updated.
> 
> http://cr.openjdk.java.net/~joehw/jdk9/8175830/webrev/src/jdk.xml.dom/share/classes/module-info.java.udiff.html <http://cr.openjdk.java.net/~joehw/jdk9/8175830/webrev/src/jdk.xml.dom/share/classes/module-info.java.udiff.html>
> 
> -Joe
> 
> On 3/7/2017 10:45 AM, Lance Andersen wrote:
>> Hi Joe,
>> 
>> I would like to suggest to consider the wording similar to what we have for other modules
>> 
>> +/**
>> + * This module contains the sub-packages in the W3C Document Object Model (DOM) API 
>> + * that are not part of the Jave SE API. 
>> + *
>> + * @since 9
>> + */
>> 
>> Perhaps change to:
>> 
>> Defines the subset of the  W3C Document Object Model (DOM) API that is not part of the Java SE API
>> 
>> HTH
>> 
>> Best
>> Lance
>> 
>>> On Mar 7, 2017, at 1:36 PM, huizhe wang <huizhe.wang at oracle.com <mailto:huizhe.wang at oracle.com>> wrote:
>>> 
>>> Hi,
>>> 
>>> Please review a module description for jdk.xml.dom.
>>> 
>>> JBS: https://bugs.openjdk.java.net/browse/JDK-8175830 <https://bugs.openjdk.java.net/browse/JDK-8175830>
>>> webrev: http://cr.openjdk.java.net/~joehw/jdk9/8175830/webrev/ <http://cr.openjdk.java.net/%7Ejoehw/jdk9/8175830/webrev/>
>>> 
>>> Thanks,
>>> Joe
>> 
>> <Mail Attachment.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif>
>>  <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif>
>>  <http://oracle.com/us/design/oracle-email-sig-198324.gif>Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037
>> Oracle Java Engineering 
>> 1 Network Drive 
>> Burlington, MA 01803
>> Lance.Andersen at oracle.com <mailto:Lance.Andersen at oracle.com>
>> 
>> 
>> 
> 

 <http://oracle.com/us/design/oracle-email-sig-198324.gif>
 <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif>
 <http://oracle.com/us/design/oracle-email-sig-198324.gif>Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037
Oracle Java Engineering 
1 Network Drive 
Burlington, MA 01803
Lance.Andersen at oracle.com <mailto:Lance.Andersen at oracle.com>





More information about the core-libs-dev mailing list