RFR: 8176709: JarFileSystem::isMultiReleaseJar is incorrect
Claes Redestad
claes.redestad at oracle.com
Wed Mar 15 18:35:16 UTC 2017
On 03/15/2017 07:33 PM, Mandy Chung wrote:
>> On Mar 15, 2017, at 11:25 AM, Claes Redestad <claes.redestad at oracle.com> wrote:
>>
>>
>>
>> On 03/15/2017 05:36 PM, Mandy Chung wrote:
>>> I would prefer to separate the performance issue from this fix and keep this fix simple. There may be more to tease out for performance regression that I defer to Sherman to discuss with you.
>> Ok:
>>
>> http://cr.openjdk.java.net/~redestad/8176709/jdk.03/
>>
>> Also fixed an additional correctness issue, as we discussed offline, in that we should only catch and swallow NoSuchFileException (when manifest is missing), and rethrow any other IOException.
> Looks good.
Thanks!
> You can take out the unused import before the push.
Also updated copyrights. Pushed.
/Claes
> Thanks for separating the performance fix from this patch.
>
> Mandy
More information about the core-libs-dev
mailing list