Review Request: JDK-8176815: Remove StackFramePermission and use RuntimePermission for stack walking

Mandy Chung mandy.chung at oracle.com
Wed Mar 15 20:38:02 UTC 2017


> On Mar 15, 2017, at 1:30 PM, Alan Bateman <Alan.Bateman at oracle.com> wrote:
> 
> On 15/03/2017 19:42, Mandy Chung wrote:
> 
>> StackWalker::getInstance is currently specified to check for StackFramePermission("retainClassReference“) due to an early review feedback .  Given it has only one target, it’s overkill to define a specific permission type for stack walking use.   This patch proposes to replace the StackWalker permission check with RuntimePermission("getStackWalkerWithClassReference”) and remove StackFramePermission class.
>> 
>> http://cr.openjdk.java.net/~mchung/jdk9/webrevs/8176815/webrev.00/
>> 
> The target name is long but I agree with removing this permission (and the changes look good).

An alternative target name is “getStackWalker” that I suggested previously but doesn’t seem attracting to other.  It’s hard to anticipate if a different target name is needed in the future.

Another reason why I’m okay with this long name because it’s one character less than another target name:

  *   <td>setDefaultUncaughtExceptionHandler</td>

Mandy


More information about the core-libs-dev mailing list