RFR[9] 8160956: Runtime.Version.compareTo/compareToIgnoreOpt problem

Paul Sandoz paul.sandoz at oracle.com
Thu Mar 16 18:05:00 UTC 2017


> On 16 Mar 2017, at 08:27, mark.reinhold at oracle.com wrote:
> 
> 2017/3/16 8:17:03 -0700, pavel.rappo at oracle.com:
>> Please review the following trivial change for [1]:
>> 
>>  http://cr.openjdk.java.net/~prappo/8160956/webrev.00/
> 
> Looks good to me.
> 
>> ...
>> 
>> P.S. While we are in this area, may I ask if anybody knows why exactly Version
>> class has lost its 'final' modifier while moving from 'jdk' package to
>> 'java.lang' [2]?
> 
> I have no idea.  This class really ought to be final.
> 

Yes, Pavel unless there is some non-obvious here (which i think is unlikely) i suggest you make it so, update your patch, test, then push!

Paul.


More information about the core-libs-dev mailing list