JDK 9 RFR of JDK-8177722: Improve grouping of jdk/internal/math tests

Stuart Marks stuart.marks at oracle.com
Wed Mar 29 00:08:37 UTC 2017


The change looks good, Joe.

s'marks

On 3/28/17 9:43 AM, joe darcy wrote:
> Hello,
>
> The tests in jdk/internal/math tests test the floating decimal code which
> underlies the base conversion functionality used in the core libraries. This
> code is not part of BigInteger or BigDecimal and is not otherwise related to the
> java.math package. Therefore, the jdk/internal/math tests are better placed in
> the jdk_lang test group rather than jdk_math.
>
> Please review the patch below which moves the test group.
>
> Thanks,
>
> -Joe
>
> diff -r e685e3197f62 test/TEST.groups
> --- a/test/TEST.groups    Mon Mar 27 18:38:58 2017 -0700
> +++ b/test/TEST.groups    Tue Mar 28 09:35:50 2017 -0700
> @@ -73,6 +73,7 @@
>      jdk/internal/misc \
>      jdk/internal/ref \
>      jdk/internal/jimage \
> +    jdk/internal/math \
>      jdk/modules \
>      vm
>
> @@ -141,8 +142,7 @@
>      java/util/stream
>
>  jdk_math = \
> -    java/math \
> -    jdk/internal/math
> +    java/math
>
>  jdk_io = \
>      java/io
>


More information about the core-libs-dev mailing list