RFR: 8175131: sun.rmi.transport.tcp.TCPChannel.createConnection close connection on timeout
Rob McKenna
rob.mckenna at oracle.com
Wed May 10 20:22:55 UTC 2017
Good point, I was nervous that there may have been a reason for not
closing the connection and completely overlooked the obvious.
http://cr.openjdk.java.net/~robm/8175131/webrev.02/
Thanks,
-Rob
On 10/05/17 03:38, Roger Riggs wrote:
> Hi Rob,
>
> If an exception is thrown in createConnection, it can't return the
> connection that was created
> and so it should close it.
>
> I would close the connection at line 298, before throwing the exception.
>
> Roger
>
> On 5/10/2017 3:25 PM, Rob McKenna wrote:
> >Hi folks,
> >
> >Looking for a review of the following simple change:
> >
> >https://bugs.openjdk.java.net/browse/JDK-8175131
> >http://cr.openjdk.java.net/~robm/8175131/webrev.01/
> >
> >Note: I've deliberately limited the connection closure to the described
> >case. If however you feel that it should be applied generally when an
> >exception is thrown (in the if and / or else block) let me know!
> >
> > -Rob
> >
>
More information about the core-libs-dev
mailing list