RFR: JDK-8180202: -XXaltjvm is not working anymore on MacOSX

[David Holmes]

Hi Kumar,

On 15/05/2017 9:54 AM, Kumar Srinivasan wrote:
> Hi David,
>
> Please review simple fix for JDK-8180202, recall we hard coded "server",
> this is incorrect because the function CheckJvmType will determin
> the correct jvmtype based on jvm.cfg *or* path/jvmtype specified by
> -XXaltjvm.  IMO all this needs to be cleaned up when jvm.cfg is removed.

So this original change was wrong:

!         const char *jvmtypeUsed = ((bitsWanted == 64) && 
(strcmp(jvmtype, "client") == 0)) ? "server" : jvmtype;
!         const char *jvmtypeUsed = "server";

because jvmType might still be something other than "server"? Not sure 
how but okay.

However I don't see the connection to -XXaltjvm as that should be 
setting a full path itself and not relying on jvmType within the 
well-known path ??

> Thanks
> Kumar
>
> PS: please also approve the removal of the test from the internal
> ProblemList.txt

Ok.

Thanks,
David

> diff in the JBS issue.
>
> diff --git a/src/java.base/macosx/native/libjli/java_md_macosx.c
> b/src/java.base/macosx/native/libjli/java_md_macosx.c
> --- a/src/java.base/macosx/native/libjli/java_md_macosx.c
> +++ b/src/java.base/macosx/native/libjli/java_md_macosx.c
> @@ -424,7 +424,7 @@
>           * macosx client library is built thin, i386 only.
>           * 64 bit client requests must load server library
>           */
> -        JLI_Snprintf(jvmpath, jvmpathsize, "%s/lib/server/" JVM_DLL,
> jrepath);
> +        JLI_Snprintf(jvmpath, jvmpathsize, "%s/lib/%s/" JVM_DLL,
> jrepath, jvmtype);
>      }
>
>      JLI_TraceLauncher("Does `%s' exist ... ", jvmpath);
>
>
>
>
>
>