RFR: 8180385: fix HTML issues in java.xml module
Lance Andersen
lance.andersen at oracle.com
Tue May 16 23:26:13 UTC 2017
Hi Jon,
Thank you for the explanation. Makes sense. No worries :-)
Best
Lance
> On May 16, 2017, at 7:02 PM, Jonathan Gibbons <jonathan.gibbons at oracle.com> wrote:
>
> Lance,
>
> The name seemed unnecessary given the context of the method associated with the doc comment (i.e getNamespaceURI) and the preceding sentence:
>
> >> the following table describes the returned Namespace URI value for all possible prefix values:
>
> If that was editorial overreach, I apologise, and can add the text back, if you would prefer.
>
> See http://cr.openjdk.java.net/~jjg/8180385/api.02/javax/xml/namespace/NamespaceContext.html#getNamespaceURI-java.lang.String <http://cr.openjdk.java.net/~jjg/8180385/api.02/javax/xml/namespace/NamespaceContext.html#getNamespaceURI-java.lang.String>-
>
> -- Jon
>
> On 05/16/2017 03:55 PM, Lance Andersen wrote:
>> Hi Jon
>>
>> src/java.xml/share/classes/javax/xml/namespace/NamespaceContext.java - Was there a reason you omitted {@code getNamespaceURI(prefix)} when creating the caption?
>> Looks pretty good otherwise
>>> On May 16, 2017, at 6:27 PM, Jonathan Gibbons <jonathan.gibbons at oracle.com <mailto:jonathan.gibbons at oracle.com>> wrote:
>>>
>>> Please review these fixes to update the public doc comments in the java.xml
>>> module for HTML 5.
>>>
>>> Webrev: http://cr.openjdk.java.net/~jjg/8180385/webrev.02/ <http://cr.openjdk.java.net/%7Ejjg/8180385/webrev.02/>
>>> API: http://cr.openjdk.java.net/~jjg/8180385/api.02/ <http://cr.openjdk.java.net/%7Ejjg/8180385/api.02/>
>>>
>>> -- Jon
>>
>> <Mail Attachment.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif>
>> <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif>
>> <http://oracle.com/us/design/oracle-email-sig-198324.gif>Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037
>> Oracle Java Engineering
>> 1 Network Drive
>> Burlington, MA 01803
>> Lance.Andersen at oracle.com <mailto:Lance.Andersen at oracle.com>
>>
>>
>>
>
<http://oracle.com/us/design/oracle-email-sig-198324.gif>
<http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif>
<http://oracle.com/us/design/oracle-email-sig-198324.gif>Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037
Oracle Java Engineering
1 Network Drive
Burlington, MA 01803
Lance.Andersen at oracle.com <mailto:Lance.Andersen at oracle.com>
More information about the core-libs-dev
mailing list