jdk10 RFR of JDK-8180732: add test to check temp file permission

Roger Riggs Roger.Riggs at Oracle.com
Tue May 23 17:05:52 UTC 2017


Hi,

Security.java: 25-27: Style conventions call for " * " on every line in 
comment blocks.

On 5/23/2017 12:53 PM, Brent Christian wrote:
> Hi, Hamlin
>
> That looks pretty good.  A couple comments:
>
> * If I'm not mistaken, main/othervm/policy=... is sufficient to enable 
> the default security manager, and specifying "-Djava.security.manager" 
> is unnecessary.
>
> * Please add 8180732 to the @bug tag

I'm not sure this adds much because the bug report just is moving to 
test to the open repo.

>
> You will also need approval from a JDK 10 Reviewer.

Roger

>
> Thanks,
> -Brent
>
> On 5/21/17 9:26 PM, Hamlin Li wrote:
>> Would you please review the below patch?
>>
>> bug: https://bugs.openjdk.java.net/browse/JDK-8180732
>> webrev: http://cr.openjdk.java.net/~mli/8180732/webrev.00/
>>
>> Thank you
>> -Hamlin



More information about the core-libs-dev mailing list