RFR(S) : 8180724: move ModuleInfoMaker to the top level testlibrary

Paul Sandoz paul.sandoz at oracle.com
Wed May 24 18:41:43 UTC 2017


+1
Paul.

> On 19 May 2017, at 16:29, Igor Ignatyev <igor.ignatyev at oracle.com> wrote:
> 
> http://cr.openjdk.java.net/~iignatyev//8180724/webrev.00/index.html
>> 295 lines changed: 139 ins; 140 del; 16 mod;
> 
> Hi all,
> 
> could you please review this small fix which moves ModuleInfoMaker class from jdk testlibrary to the top level testlibrary? since ModuleInfoMaker depends on CompilerUtil and thus on jdk.compiler module, it has been placed to jdk.test.lib.compiler package to avoid unneeded module dependency in tests. HashesTest has been updated to use ModuleInfoMaker::compile instead of using CompilerUtils::compile directly.
> 
> webrev: http://cr.openjdk.java.net/~iignatyev//8180724/webrev.00/index.html
> jbs: https://bugs.openjdk.java.net/browse/JDK-8180724
> testing: affected tests (jdk/test/tools/launcher)
> 
> Thanks,
> -- Igor



More information about the core-libs-dev mailing list