RFR 8166139/10, Refactor java/net shell cases to java

Roger Riggs Roger.Riggs at Oracle.com
Thu May 25 19:24:10 UTC 2017


Hi Felix,

closetest/CloseTest:

32: Please put the @modules directives together (and not repeat)

44: do not use wildcard imports  (reconfigure your IDE if necessary to 
avoid accidents).

63: setup() is invoked twice...  remove 1 or explain why 2 calls

69, 78,90,91,... :  space in method call is not proper style

sealing/CheckSealed.java:
  - Why is @test block removed?
     Should be converted to @run main CheckSealed

Regards, Roger



On 5/25/2017 4:08 AM, Felix Yang wrote:
> Hi there,
>
>    please review following patch to convert all shell cases under 
> java/net to plain java codes.
>
> Webrev:
>
>     http://cr.openjdk.java.net/~xiaofeya/8166139/webrev.00/
>
> Bug:
>
>     https://bugs.openjdk.java.net/browse/JDK-8166139
>
>
> Thanks,
>
> Felix
>



More information about the core-libs-dev mailing list