RFR 9+-: 8180582: The bind to rmiregistry is rejected by registryFilter even though registryFilter is set

Roger Riggs Roger.Riggs at Oracle.com
Wed May 31 14:02:24 UTC 2017


Thanks Daniel for the review and corrected link.

On 5/30/2017 7:04 PM, Daniel Fuchs wrote:
> Hi Roger,
>
> On 30/05/17 19:26, Roger Riggs wrote:
>> Hi Daniel,
>>
>> Fixed, there is no need for the unbind since the registry is not 
>> reused and it might
>> cause a spurious success.
>>
>> (Also corrected the exception error message @ 151 and 153).
>>
>> Webrev updated in place.
>> ...
>
> I assume you meant
> http://cr.openjdk.java.net/~rriggs/webrev-depth-max-8180582/index.html
> which is what I reviewed ;-)
>
> Looks good!
>
> -- danel
>
>>
>> Thanks, Roger
>>
>>
>> On 5/30/2017 2:00 PM, Daniel Fuchs wrote:
>>> Hi Roger,
>>>
>>> Looks good! Just one nit with the test:
>>>
>>>  194             registry.unbind(name);
>>>  195             Assert.fail("Registry filter should have rejected 
>>> depth: " + depthOverride + 1);
>>>
>>> Technically, the test will also pass if bind() succeed but
>>> unbind() fails - for some unforeseen reason.
>>>
>>> best regards,
>>>
>>> -- daniel
>>>
>>> On 25/05/17 16:31, Roger Riggs wrote:
>>>> Please review an update to the RMI Registry built-in serial filter 
>>>> implementation limit on the depth
>>>> of a instance that can be bound in the registry.  The initial depth 
>>>> limit was 5 and it was too limiting
>>>> for some existing applications.  It limit is updated to depth = 20 
>>>> and should be more than adequate.
>>>>
>>>> Webrev:
>>>> http://cr.openjdk.java.net/~rriggs/webrev-depth-max-8180582/index.html
>>>>
>>>> Issue:
>>>> https://bugs.openjdk.java.net/browse/JDK-8180582
>>>>
>>>> Thanks, Roger
>>>
>>
>



More information about the core-libs-dev mailing list