RFR 8191173 : (cl) Clarify or remove "for delegation" in ClassLoader spec
Martin Buchholz
martinrb at google.com
Tue Nov 21 21:03:57 UTC 2017
Looks good!
On Tue, Nov 21, 2017 at 12:41 PM, Brent Christian <
brent.christian at oracle.com> wrote:
> Hi,
>
> Please review my change to this small bit of ClassLoader spec that can be
> tidied up, as noticed by Martin.
>
> Issue:
> https://bugs.openjdk.java.net/browse/JDK-8191173
> Webrev:
> http://cr.openjdk.java.net/~bchristi/8191173/webrev.00/
>
> In java.lang.ClassLoader these methods:
> getParent()
> getPlatformClassLoader()
> getSystemClassLoader()
> all state that the returned classloader is, "for delegation."
>
> For getParent() this makes sense to mention. But it seems unnecessary for
> the other two methods, which are static, and designed to always return the
> indicated classloader. The getSystemClassLoader() docs go on to
> immediately mention that the system classloader is the default delegation
> parent.
>
> Omitting the phrase makes the spec more concise.
>
> Thanks,
> -Brent
>
More information about the core-libs-dev
mailing list