<i18n dev> [10] RFR 8176841: Additional Unicode Language-Tag Extensions

[Stephen Colebourne]

This fixes my previous points, so fine by me. But I am not an OpenJDK reviewer.
Stephen

On 27 November 2017 at 20:54, Naoto Sato <naoto.sato at oracle.com> wrote:
> Thanks, Stephen. Here is the updated webrev:
>
> http://cr.openjdk.java.net/~naoto/8176841.8189134.8190918.8191349/webrev.06/
>
> Naoto
>
>
> On 11/23/17 8:13 AM, Stephen Colebourne wrote:
>>
>> In DateTimeFormatter line 1508, this would be preferred:
>>
>>    return  new DateTimeFormatter(printerParser, locale, ds,
>> resolverStyle, resolverFields, c, z);
>>
>> In DateTimeFormatterBuilder.getLocalizedDateTimePattern() there is no
>> spec change wrt using "rg".
>>
>> Should findRegionOverride() just return a Locale instead of am
>> Optional<Locale>? It always seems to have an orElse(locale).
>>
>> Java-Time tests look good.
>>
>> thanks
>> Stephen
>>
>>
>> On 22 November 2017 at 19:04, Naoto Sato <naoto.sato at oracle.com> wrote:
>>>
>>> I revised the proposed changes, including java.time changes suggested by
>>> Stephen (CSR is still in progress):
>>>
>>> https://bugs.openjdk.java.net/browse/JDK-8191349
>>>
>>> The entire webrev is located at:
>>>
>>>
>>> http://cr.openjdk.java.net/~naoto/8176841.8189134.8190918.8191349/webrev.05/
>>>
>>> And the diff webrev from the last one is located at:
>>>
>>> http://cr.openjdk.java.net/~naoto/8191349/webrev.04-05/
>>>
>>> I'd appreciate your reviews.
>>>
>>> Naoto
>>>
>>>
>>>
>>> On 11/9/17 3:34 PM, Naoto Sato wrote:
>>>>
>>>>
>>>> Kindly requesting reviews. I incorporated a fix to the following issue
>>>> raised by the test team:
>>>>
>>>> https://bugs.openjdk.java.net/browse/JDK-8190918
>>>>
>>>> Here is the updated webrev:
>>>>
>>>> http://cr.openjdk.java.net/~naoto/8176841.8189134.8190918/webrev.04/
>>>>
>>>> And the webrev since the one below (to address 8190918):
>>>>
>>>> http://cr.openjdk.java.net/~naoto/8190918/
>>>>
>>>> Naoto
>>>>
>>>>
>>>>
>>>> On 11/2/17 2:42 PM, Naoto Sato wrote:
>>>>>
>>>>>
>>>>> Hello,
>>>>>
>>>>> Please review the proposed changes for the following issues:
>>>>>
>>>>> 8176841: Additional Unicode Language-Tag Extensions
>>>>> 8189134: New system properties for the default Locale extensions
>>>>>
>>>>> The proposed changeset is located at:
>>>>>
>>>>> http://cr.openjdk.java.net/~naoto/8176841/webrev.03/
>>>>>
>>>>> This serves as the implementation of JEP 314.
>>>>>
>>>>> Naoto
>>>>>
>>>>>
>>>>>
>>>
>