RFR (JDK10/JAXP) 8191938: Fix lint warnings in JAXP repo: a few Deprecation warrnings and enable -Xlint:all

joe darcy joe.darcy at oracle.com
Wed Nov 29 19:45:03 UTC 2017


Hi Joe,

The new version looks fine to me; thanks,

-Joe


On 11/29/2017 10:58 AM, Joe Wang wrote:
> Hi Joe,
>
> I moved the LastModified to the bottom of the class comment block. 
> Please let me know what you think:
> http://cr.openjdk.java.net/~joehw/jdk10/8191938/webrev/index.html
>
> Thanks,
> Joe
>
> On 11/28/17, 10:19 AM, joe darcy wrote:
>> Hi Joe,
>>
>> The code changes look fine, but the copyright blocks should *not* be 
>> updated to include a "@LastModified: Nov 2017" comment.
>>
>> Cheers,
>>
>> -Joe
>>
>>
>> On 11/28/2017 10:11 AM, Joe Wang wrote:
>>> Hi,
>>>
>>> Please review a fix for a few more deprecation warnings. Compiling 
>>> with -Xlint:all showed that these were the last few warnings. We can 
>>> then enable -Xlint:all for the java.xml module.
>>>
>>> JBS: https://bugs.openjdk.java.net/browse/JDK-8191938
>>> webrevs: http://cr.openjdk.java.net/~joehw/jdk10/8191938/webrev/
>>>
>>> Thanks,
>>> Joe
>>



More information about the core-libs-dev mailing list