RFR (JDK10/JAXP) 8191938: Fix lint warnings in JAXP repo: a few Deprecation warrnings and enable -Xlint:all
Joe Wang
huizhe.wang at oracle.com
Thu Nov 30 19:25:02 UTC 2017
Hi Jon, all,
For the LastModified tag, yes, "make docs" was fine. Note that it will
appear only in impl classes.
For the webrev, I also updated the javac flag from doclint:none to a set
of java.xml public packages that we care about.
http://cr.openjdk.java.net/%7Ejoehw/jdk10/8191938/webrev/
Thanks,
Joe
On 11/29/17, 2:11 PM, Jonathan Gibbons wrote:
> Joe,
>
> I presume javadoc is OK with this not-quite-a-doc-comment-tag, when
> you do "make docs" ...
>
> -- Jon
>
>
> On 11/29/2017 10:58 AM, Joe Wang wrote:
>> Hi Joe,
>>
>> I moved the LastModified to the bottom of the class comment block.
>> Please let me know what you think:
>> http://cr.openjdk.java.net/~joehw/jdk10/8191938/webrev/index.html
>>
>> Thanks,
>> Joe
>>
>> On 11/28/17, 10:19 AM, joe darcy wrote:
>>> Hi Joe,
>>>
>>> The code changes look fine, but the copyright blocks should *not* be
>>> updated to include a "@LastModified: Nov 2017" comment.
>>>
>>> Cheers,
>>>
>>> -Joe
>>>
>>>
>>> On 11/28/2017 10:11 AM, Joe Wang wrote:
>>>> Hi,
>>>>
>>>> Please review a fix for a few more deprecation warnings. Compiling
>>>> with -Xlint:all showed that these were the last few warnings. We
>>>> can then enable -Xlint:all for the java.xml module.
>>>>
>>>> JBS: https://bugs.openjdk.java.net/browse/JDK-8191938
>>>> webrevs: http://cr.openjdk.java.net/~joehw/jdk10/8191938/webrev/
>>>>
>>>> Thanks,
>>>> Joe
>>>
>
More information about the core-libs-dev
mailing list