[10] RFR(XS) 8188776: jdk.internal.vm.ci can't export package to upgradeable modules

Vladimir Kozlov vladimir.kozlov at oracle.com
Wed Oct 4 23:34:23 UTC 2017


Thank you, Mandy

On 10/4/17 4:15 PM, mandy chung wrote:
> +1
> 
> Looks like JDK regression tests were not run before pushing JDK-8182701?

Yes, only hotspot jtreg tests were run unfortunately before the push.
We do run jdk_lang regularly in tier5 Nightly testing.

Thanks,
Vladimir

> 
> Mandy
> 
> On 10/4/17 4:12 PM, Vladimir Kozlov wrote:
>> https://bugs.openjdk.java.net/browse/JDK-8188776
>>
>> 8182701 added exports for jdk.vm.ci.runtime package [1] but did not add new exception in the test.
>>
>> Added missing exception in JdkQualifiedExportTest.java test:
>>
>> --- a/test/jdk/jdk/modules/etc/JdkQualifiedExportTest.java
>> +++ b/test/jdk/jdk/modules/etc/JdkQualifiedExportTest.java
>> @@ -70,6 +70,7 @@
>>
>>      static Set<String> KNOWN_EXCEPTIONS =
>>          Set.of("jdk.internal.vm.ci/jdk.vm.ci.services",
>> +               "jdk.internal.vm.ci/jdk.vm.ci.runtime",
>> "jdk.jsobject/jdk.internal.netscape.javascript.spi");
>>
>>      static void checkExports(ModuleDescriptor md) {
>>
>> Verified with this test.
>>
>> Thanks,
>> Vladimir
>>
>> [1] http://hg.openjdk.java.net/jdk10/hs/rev/8b2054b7d02c#l3.1
> 


More information about the core-libs-dev mailing list