RFR (JDK10/JAXP) 8181150: Fix lint warnings in JAXP repo: rawtypes and unchecked

Roger Riggs roger.riggs at oracle.com
Wed Oct 18 17:57:24 UTC 2017


Hi Joe,

The changes look fine.

Maybe do them in smaller batches next time with a consistent kind of 
change. Just thought.

Thanks, Roger


On 10/12/17 11:24 AM, Joe Wang wrote:
> Hi,
>
> Please review a cleanup of rawtypes and unchecked warnings from JAXP 
> sources.
>
> The patch involved a good number of classes (278). However, the 
> majority of the changes are straight-forward replacement, e.g. 
> s/Vector/List[ArrayList] and their relevant methods e.g. 
> s/elementAt/get and etc. In a few cases, 
> ArrayIndexOutOfBoundsException was substituted with 
> IndexOutOfBoundsException as they were caught.
>
> A few cleanups unrelated to rawtypes and unchecked were made before 
> Roger's suggestion to stay within the scope of the request, that is, a 
> couple of StringBuffer substitution, other than that this changeset is 
> almost rawtypes and unchecked cleanup only.
>
> JBS: https://bugs.openjdk.java.net/browse/JDK-8181150
> webrevs: http://cr.openjdk.java.net/~joehw/jdk10/8181150/webrev/
>
> Thanks,
> Joe
>



More information about the core-libs-dev mailing list