Review Request JDK-8187089: StringConcatFactory.makeConcat & makeConcatWithConstants should throw StringConcatException if parameter slot count is over 200

mandy chung mandy.chung at oracle.com
Wed Oct 18 23:32:15 UTC 2017


StringConcatFactory::makeConcat and makeConcatWithConstants APIs are
specified to accept concatType to have a maximum of 200 parameter slots.
If violated, it should throw StringConcatException.  The implementation
mistakenly checks the parameter count.  The javadoc of these methods
states "parameter count" rather than "parameter slots" whereas
@apiNote in the class spec correctly says "parameter slots".

Webrev:
http://cr.openjdk.java.net/~mchung/jdk10/webrevs/8187089/webrev.00/

CSR:
    https://bugs.openjdk.java.net/browse/JDK-8189634

Thanks
Mandy


More information about the core-libs-dev mailing list