RFR (JDK10/JAXP) 8181155: Fix lint warnings in JAXP repo: fallthrough and static

Joe Wang huizhe.wang at oracle.com
Mon Oct 30 17:25:40 UTC 2017


Thanks Lance!

Best,
Joe

On 10/30/17, 10:09 AM, Lance Andersen wrote:
> Hi Joe
>
> The changes look OK
>
> Best
> Lance
>> On Oct 30, 2017, at 1:03 PM, Joe Wang <huizhe.wang at oracle.com 
>> <mailto:huizhe.wang at oracle.com>> wrote:
>>
>> Hi,
>>
>> Please review a cleanup of fallthrough and static warnings. For 
>> fallthrough, the majority of the changes are suppressing the 
>> warnings, while for static, replacing the instances with the class.
>>
>> All jaxp tests and JCK passed.
>>
>> JBS: https://bugs.openjdk.java.net/browse/JDK-8181155
>> webrevs: 
>> http://cr.openjdk.java.net/~joehw/jdk10/8181155/webrev/index.html 
>> <http://cr.openjdk.java.net/%7Ejoehw/jdk10/8181155/webrev/index.html>
>>
>> Thanks,
>> Joe
>
> <http://oracle.com/us/design/oracle-email-sig-198324.gif>
> <http://oracle.com/us/design/oracle-email-sig-198324.gif><http://oracle.com/us/design/oracle-email-sig-198324.gif>
> <http://oracle.com/us/design/oracle-email-sig-198324.gif>Lance 
> Andersen| Principal Member of Technical Staff | +1.781.442.2037
> Oracle Java Engineering
> 1 Network Drive
> Burlington, MA 01803
> Lance.Andersen at oracle.com <mailto:Lance.Andersen at oracle.com>
>
>
>


More information about the core-libs-dev mailing list