RFR JDK-8186751: Add ISO-8859-16 Charset support

Ulf Zibis Ulf.Zibis at CoSoCo.de
Fri Sep 1 18:22:39 UTC 2017


Hi again,


Am 31.08.2017 um 23:29 schrieb Xueming Shen:
> The 8859-16 aliases are the copy/paste from
> https://www.iana.org/assignments/character-sets/character-sets.xhtml
>
> From the same page we have the followings for 8859-15
> ISO_8859-15
> Latin-9
> csISO885915
>
> It appears only the first one is listed in our alias list (explicitly 
> commented).
> Don't have the memory for the history (8859-15 was added a long time ago),
> not sure whether the other two were missed at the very beginning or were
> added later in the iana. Since we are here, I added them in.

Fine!

> http://cr.openjdk.java.net/~sherman/8186751/webrev
> (the old one is copied to webrev.00)

- I think, the comment should now be in plural: # IANA alias*es
*- Also I think, it would make sense to at least add "ISO8859-16" and 
"ISO8859_16" as # Other aliases
- "ISO-8859-15" must not be listed as alias, as it already is the 
canonical name.
- Not sure, where "LATIN0" and "csISOlatin0" come from.

-Ulf



More information about the core-libs-dev mailing list