RFR JDK-8186464: ZipFile cannot read some InfoZip ZIP64 zip files
Xueming Shen
xueming.shen at oracle.com
Fri Sep 1 23:17:54 UTC 2017
On 8/22/17, 5:54 PM, Martin Buchholz wrote:
>
>
> On Tue, Aug 22, 2017 at 3:27 PM, Xueming Shen <xueming.shen at oracle.com
> <mailto:xueming.shen at oracle.com>> wrote:
>
>
> How about to add an option to our zipfs to force the ZIP64 end
> record when
> enabled. Harmless if not specified.
>
>
> I agree that adding more options for testability is good. Since our
> users are likely to need such things as well, I'd also like to see
> such features become public, analogous to zip's -fz- flag.
>
> OTOH, interoperability testing is very valuable, so despite the
> troubles involved writing tests that involve both jdk and zipinfo
> code, I think we should do it.
>
Martin,
I have added a test case that tests "echo hello | zip infozip.zip -" via
pb.startPipeline()
in ReadZip.java, which should add some coverage for the
"interoperability testing".
Would you please help take a look?
http://cr.openjdk.java.net/~sherman/8186464/webrev/
Thanks,
Sherman
More information about the core-libs-dev
mailing list