[10] RFR of JDK-8184329: Refactor java/lang/ClassLoader shell tests to java

Amy Lu amy.lu at oracle.com
Fri Sep 22 04:31:48 UTC 2017


On 9/22/17 2:50 AM, mandy chung wrote:
>
>
> On 9/20/17 10:52 PM, Amy Lu wrote:
>> test/jdk/java/lang/ClassLoader/getdotresource.sh
>>
>> Please review this patch to refactor the shell test to java.
>>
>> bug: https://bugs.openjdk.java.net/browse/JDK-8184329
>> webrev: http://cr.openjdk.java.net/~amlu/8184329/webrev.00/
> I think you can replace line 64-67 with
> ProcessTools.executeTestJava("-cp", CP, 
> GetDotResource.class.getName(), DOT_FILENAME)
> Mandy

Hi, Mandy

webrev updated, please review:
http://cr.openjdk.java.net/~amlu/8184329/webrev.01

(I'll file bug for the inconsistent of adding "-cp" in 
executeTestJavainjdk.test.lib.process.ProcessTools and 
jdk.testlibrary.ProcessTools, so as this won't be forgotten when trying 
to remove jdk.testlibrary.ProcessTools)

Thanks,
Amy



More information about the core-libs-dev mailing list