RFR(XS): 8188135: Fix VS 2010 build after "8187631: Refactor FileDescriptor close implementation"

Lindenmaier, Goetz goetz.lindenmaier at sap.com
Fri Sep 29 09:13:49 UTC 2017


Thanks David!

... at least SAP got rid of gcc 4.1.2 :)

Best regards,
 Goetz.

> -----Original Message-----
> From: David Holmes [mailto:david.holmes at oracle.com]
> Sent: Freitag, 29. September 2017 10:33
> To: Lindenmaier, Goetz <goetz.lindenmaier at sap.com>; core-libs-
> dev at openjdk.java.net
> Subject: Re: RFR(XS): 8188135: Fix VS 2010 build after "8187631: Refactor
> FileDescriptor close implementation"
> 
> On 29/09/2017 6:05 PM, Lindenmaier, Goetz wrote:
> > Hi,
> >
> > please review this tiny fix for the build with Visual Studio 2010:
> > http://cr.openjdk.java.net/~goetz/wr17/8188135-winBuild/webrev.01/
> 
> Looks fine.
> 
> One day we'll stop getting bitten by archaic compilers :(
> 
> Cheers,
> David
> 
> > Best regards,
> >    Goetz.
> >


More information about the core-libs-dev mailing list