RFR: 8184692: add Pattern.asMatchPredicate
Paul Sandoz
paul.sandoz at oracle.com
Fri Apr 6 01:25:15 UTC 2018
> On Apr 4, 2018, at 10:47 AM, Vivek Theeyarath <vivek.theeyarath at oracle.com> wrote:
>
> Hi All,
>
> Please review.
>
> Bug: https://bugs.openjdk.java.net/browse/JDK-8184692
>
> Webrev : http://cr.openjdk.java.net/~vtheeyarath/8184692/webrev.00/
>
Like with your other patch, alignment to ~80 chars would be good, as that is mostly consistent with other code in the same source file.
Let’s not use the word “find" here, so as not to confuse with matcher(s).find().
5833 * @return The predicate which can be used for finding if an input string matches this pattern.
I suggest:
@return The predicate which can be used for matching an input string against this pattern
You could also add a @see Matcher#matches
Paul.
>
>
> The related jtreg test was run and the test passed .
>
>
>
> Regards
>
> Vivek
More information about the core-libs-dev
mailing list