8194734 : Handle to jimage file inherited into child processes (win)

Martin Buchholz martinrb at google.com
Sun Apr 8 19:09:46 UTC 2018


I'm hoping that JDK core libraries overall do a better job of reusing the
code in e.g.
src/hotspot/os/linux/os_linux:os::open
somehow, that actually gets the CLOEXEC bit right.

On Sun, Apr 8, 2018 at 11:56 AM, Alexander Miloslavskiy <
alexandr.miloslavskiy at gmail.com> wrote:

> I'm still only half paying attention, but I agree with Alexander that the
>> low-level infrastructure in libjimage is fishy.  The rule should be that
>> file descriptors created by the JDK should have the CLOEXEC bit on.
>>
>> But even if the CLOEXEC bit was forgotten, the subprocess code should
>> still succeed in closing that fd and use FAIL_FILENO for the error
>> reporting pipe in childproc.c.
>>
>
> That's two independent problems and I suggest adressing them one at a time.
>
> I anyone willing to get my patch applied? I do not have commiter rights
> yet, but my OCA is already processed.
>


More information about the core-libs-dev mailing list