RFR: 8184692: add Pattern.asMatchPredicate

[Vivek Theeyarath]

Thanks Paul / Roger for the inputs.
I have updated the javadoc based on the inputs. http://cr.openjdk.java.net/~vtheeyarath/8184692/webrev.03 . Please review.

Regards
Vivek
-----Original Message-----
From: Paul Sandoz 
Sent: Monday, April 09, 2018 9:25 PM
To: Roger Riggs <roger.riggs at oracle.com>
Cc: Core-Libs-Dev <core-libs-dev at openjdk.java.net>
Subject: Re: RFR: 8184692: add Pattern.asMatchPredicate



> On Apr 9, 2018, at 8:41 AM, Roger Riggs <Roger.Riggs at Oracle.com> wrote:
> 
> Hi Vivek,
> 
> As with Pattern.asPredicate the first sentence can be improved.
> 
>   Creates a predicate that tests if this pattern matches the entire region.
> 

The region of what? region is clear from the context of a Matcher, but less so from the context of Pattern.

Paul.

> 5833: As with the original issue, perhaps adding the word 'whole' or 
> 'entire' will make it clearer that the pattern must match then entire input string.
> 

> 5827:  Split into two sentences, the second one starting  "For example,"
> 
> 5840: add a blank line between methods
> 
> Regards, Roger
> 
> 
> On 4/9/18 5:05 AM, Vivek Theeyarath wrote:
>> Hi,
>> 	Please find the updated webrev after incorporating Paul's comments. 
>> http://cr.openjdk.java.net/~vtheeyarath/8184692/webrev.02/
>> 
>> Also, I have created a csr for this issue https://bugs.openjdk.java.net/browse/JDK-8201308 .
>> 
>> Regards
>> Vivek
>> -----Original Message-----
>> From: Paul Sandoz
>> Sent: Friday, April 06, 2018 6:55 AM
>> To: Vivek Theeyarath <vivek.theeyarath at oracle.com>
>> Cc: Core-Libs-Dev <core-libs-dev at openjdk.java.net>
>> Subject: Re: RFR: 8184692: add Pattern.asMatchPredicate
>> 
>> 
>> 
>>> On Apr 4, 2018, at 10:47 AM, Vivek Theeyarath <vivek.theeyarath at oracle.com> wrote:
>>> 
>>> Hi All,
>>> 
>>>               Please review.
>>> 
>>> Bug: https://bugs.openjdk.java.net/browse/JDK-8184692
>>> 
>>> Webrev : http://cr.openjdk.java.net/~vtheeyarath/8184692/webrev.00/
>>> 
>> Like with your other patch, alignment to ~80 chars would be good, as that is mostly consistent with other code in the same source file.
>> 
>> Let’s not use the word “find" here, so as not to confuse with matcher(s).find().
>> 
>> 5833      * @return  The predicate which can be used for finding if an input string matches this pattern.
>> 
>> I suggest:
>> 
>> @return  The predicate which can be used for matching an input string 
>> against this pattern
>> 
>> You could also add a @see Matcher#matches
>> 
>> Paul.
>> 
>>> 
>>> The related jtreg test was run and the test passed .
>>> 
>>> 
>>> 
>>> Regards
>>> 
>>> Vivek
>