RFR: JDK-8194750,Console.readPassword does not save/restore tty settings

[Xueming Shen]

Thanks!

webrev has been updated accordingly as suggested.
http://cr.openjdk.java.net/~sherman/8194750/webrev

sherman


On 4/16/18, 7:20 PM, Martin Buchholz wrote:
> Thanks, this looks good.
>
> But I have my usual nitpicky comments
>
>   376     // sets the console echo on/off
>   377     private static native boolean echo(boolean on) throws IOException;
>
> I would document the return value.
>   @returnsthe previous console echo on/off status
>
>   314                 boolean echoWasOn = true;
> I much prefer leaving it blank (in Java, not C !)
>
> boolean echoWasOn;
>
> relying on definite assignment in Java for safety.
>