RFR: JDK-8194750,Console.readPassword does not save/restore tty settings

Xueming Shen xueming.shen at oracle.com
Tue Apr 17 17:29:55 UTC 2018


On 04/17/2018 12:13 AM, Alan Bateman wrote:
>
>
> On 17/04/2018 06:15, Xueming Shen wrote:
>> Thanks!
>>
>> webrev has been updated accordingly as suggested.
>> http://cr.openjdk.java.net/~sherman/8194750/webrev
> Just catching on this one. The changes looks good, I'm just wondering if there is any way to create a reliable test for this.
>
> -Alan

It's possible to add something into the regression test (in closed now) that I wrote
before built on expect to verify the "echo" status before and after. But given "expect"
itself is not that reliable on all platforms and it's in closed, it might not be worth the
effort. Any suggestion?

sherman


More information about the core-libs-dev mailing list