[12] (AIX) 8207744: Clean up inconsistent use of opendir/closedir versus opendir64/closedir64

Baesken, Matthias matthias.baesken at sap.com
Thu Aug 2 12:24:00 UTC 2018


Hi Brian ,  builds + tests  ( with your  change  included)    last night on AIX were good .

However while looking into the coding a bit more, I noticed the following :

IBM states for AIX  :

https://www.ibm.com/support/knowledgecenter/no/ssw_aix_72/com.ibm.aix.basetrf1/opendir.htm

Note An open directory by opendir64 subroutine must always be closed with the closedir64 subroutine to ensure that the next attempt to open that directory is successful. In addition,
it must be operated using the 64-bit interfaces (readdir64, telldir64, seekdir64, rewinddir64, and closedir64) to obtain the correct directory information.


However this is  currently not the case everywhere  : for example I see in

http://cr.openjdk.java.net/~bpb/8207744/webrev.01/src/java.base/share/native/libjli/wildcard.c.frames.html

a readdir   (without 64).

Same for
http://cr.openjdk.java.net/~bpb/8207744/webrev.01/raw_files/new/src/java.base/unix/native/libjava/ProcessHandleImpl_unix.c



Best regards, Matthias




From: Brian Burkhalter <brian.burkhalter at oracle.com>
Sent: Mittwoch, 1. August 2018 16:53
To: Baesken, Matthias <matthias.baesken at sap.com>
Cc: Langer, Christoph <christoph.langer at sap.com>
Subject: Re: [12] (AIX) 8207744: Clean up inconsistent use of opendir/closedir versus opendir64/closedir64

Hi Matthias

On Aug 1, 2018, at 3:51 AM, Baesken, Matthias <matthias.baesken at sap.com<mailto:matthias.baesken at sap.com>> wrote:


 [F]irst sorry for  the messed up previous  mail .
I forgot  to fix the subject and remove some parts  of the digest ☹ .

No worries.


Hi Brian , I'll build it on AIX  +  in case it  builds  fine put it into our test patch
queue .

Build was fine on AIX .
I put it into our test patch queue and  come back to your tomorrow with  some info about the tests .

Thank you very much!

Best regards,

Brian

PS I will still need an imprimatur from a JDK 12 Reviewer.


More information about the core-libs-dev mailing list