RFR8194230, jdk/internal/jrtfs/remote/RemoteRuntimeImageTest.java fails with NPE

Alan Bateman Alan.Bateman at oracle.com
Mon Aug 6 10:23:36 UTC 2018


On 31/07/2018 07:16, Felix Yang wrote:
> Hi all,
>
>     please review a patch to improve the checking on the settings. 
> Originally it will throw NPE, if specified path is invalid.
>
> Bug:
>
>     https://bugs.openjdk.java.net/browse/JDK-8194230
>
> Webrev:
>
>     http://cr.openjdk.java.net/~xiaofeya/8194230/webrev.00/
Have you considered merging getJdk8Path and isJdk8 so that it simple 
checks for the release file and rejects the value of JDK8_HOME when it 
doesn't exist? I think that should reduce the number of checks and keep 
it very simple.

-Alan


More information about the core-libs-dev mailing list