RFR 8208364: java/lang/reflect/callerCache/ReflectionCallerCacheTest.java missing module dependencies declaration

Alexandre (Shura) Iline alexandre.iline at oracle.com
Mon Aug 6 22:22:28 UTC 2018


There was extra space before the star in "by reflection API” line. I have removed it.

-  *         by reflection API
+ *         by reflection API

> On Aug 6, 2018, at 3:19 PM, Jonathan Gibbons <jonathan.gibbons at oracle.com> wrote:
> 
> You might check the indentation of the modified lines.
> 
> -- Jon
> 
> On 08/06/2018 03:10 PM, mandy chung wrote:
>> +1
>> 
>> Mandy
>> 
>> On 8/6/18 1:51 PM, Alexandre (Shura) Iline wrote:
>>> Hi,
>>> 
>>> Please taka a quick look on this fix:
>>> 
>>> $ hg diff
>>> --- a/test/jdk/java/lang/reflect/callerCache/ReflectionCallerCacheTest.java
>>> +++ b/test/jdk/java/lang/reflect/callerCache/ReflectionCallerCacheTest.java
>>> @@ -25,8 +25,9 @@
>>>   * @test
>>>   * @bug 8202113
>>>   * @summary Test the caller class loader is not kept strongly reachable
>>> -  *         by reflection API
>>> + *         by reflection API
>>>   * @library /test/lib/
>>> + * @modules jdk.compiler
>>>   * @build ReflectionCallerCacheTest Members jdk.test.lib.compiler.CompilerUtils
>>>   * @run testng/othervm ReflectionCallerCacheTest
>>>   */
>>> $
>>> 
>>> Thank you.
>>> 
>>> Shura
>>> 
> 



More information about the core-libs-dev mailing list