[12] (AIX) 8207744: Clean up inconsistent use of opendir/closedir versus opendir64/closedir64

Brian Burkhalter brian.burkhalter at oracle.com
Thu Aug 9 20:56:21 UTC 2018


Hello,

The latest build + test runs with the .03 revision of this patch check out on AIX, Linux-x64, macOS, Solaris-sparc, and Windows-x64.

If there is a Reviewer available who approves of these changes then please do so.

Thanks,

Brian

On Aug 7, 2018, at 3:41 PM, Brian Burkhalter <brian.burkhalter at oracle.com> wrote:

> Hi Matthias,
> 
> Yes, that was intentional. From the documentation it looks as if the Linux / Solaris *64 functions in question are now legacy so I changed them for hopefully better consistency. I did not see any problems in building or testing with these changes. If someone knows these changes to be incorrect then I would appreciate being so informed.
> 
> Does this latest (.03) patch check out on AIX?
> 
> Thanks,
> 
> Brian
> 
> On Aug 7, 2018, at 3:12 AM, Baesken, Matthias <matthias.baesken at sap.com> wrote:
> 
>> small remark from my side ,  looks like you changed in
>> 
>> src/java.base/unix/native/libjava/TimeZone_md.c
>> 
>> src/java.base/unix/native/libjava/childproc.c
>> 
>> and
>> 
>> src/jdk.management/unix/native/libmanagement_ext/OperatingSystemImpl.c
>> 
>> at some places  dirent64  /  readdir64   to   dirent  /  readdir
>> in the linux/solaris  coding.
>> 
>> for example
>> 
>> TimeZone_md.c
>> 
>> 122 static char *
>> 123 findZoneinfoFile(char *buf, size_t size, const char *dir)
>> 124 {
>> 125     DIR *dirp = NULL;
>> 126     struct stat statbuf;
>> 127     struct dirent *dp = NULL;.
>> 
>> 
>> Was it intended  to  change for linux/solaris ?
> 



More information about the core-libs-dev mailing list