RFR 8209184: JDK8 ResourceBundle vulnerable to GC (fix included)
mandy chung
mandy.chung at oracle.com
Thu Aug 16 17:57:01 UTC 2018
On 8/16/18 2:16 AM, Adam Farley8 wrote:
> Hi Mandy,
>
> I request that you review this for 8u.
>
> ------------------------------------------------------
> @@ -1398,10 +1398,18 @@
> bundle = baseBundle;
> }
>
> + keepAlive(loader);
> return bundle;
> }
>
> /**
> + * Keeps the argument ClassLoader alive.
> + */
> + private static void keepAlive(ClassLoader loaderone){
> + //Do nothing.
> + }
> +
> + /**
> * Checks if the given <code>List</code> is not null, not empty,
> * not having null in its elements.
> */
> ------------------------------------------------------
Looks fine. Nit: a space before "Do nothing" comment would be good.
No need for a new diff.
Mandy
More information about the core-libs-dev
mailing list