RFR(JDK12/JAXP/java.xml) 8209615: ParseError in XMLEventReader on a valid input

[Lance Andersen]

Hi Joe,

The change and test look fine.  I assume the test for 8158619 is still happy :-)

Best
lance


> On Aug 21, 2018, at 2:17 PM, Joe Wang <huizhe.wang at oracle.com> wrote:
> 
> Hi,
> 
> Please review a patch for a regression that was introduced in JDK 9 b147 by the patch for JDK-8158619[1]. Prior to JDK-8158619, the JDK parser returns all contiguous character data in a single chunk. After the patch then, the parser would return partially if the data is not read completely in the current buffer. Before it returns however, it should have maintained the state so that it could continue parsing as CDATA for the next read. What's missing in the JDK-8158619 therefore was to set the state explicitly to CDATA. Without doing so, the parser would attempt to read the beginning of the next buffer to determine the state, that sometimes (as in this case) could be wrong.
> 
> JBS: https://bugs.openjdk.java.net/browse/JDK-8209615
> webrevs: http://cr.openjdk.java.net/~joehw/jdk12/8209615/webrev/
> 
> 
> [1] https://bugs.openjdk.java.net/browse/JDK-8158619
> 
> Thanks,
> Joe
> 

 <http://oracle.com/us/design/oracle-email-sig-198324.gif>
 <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif>
 <http://oracle.com/us/design/oracle-email-sig-198324.gif>Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037
Oracle Java Engineering 
1 Network Drive 
Burlington, MA 01803
Lance.Andersen at oracle.com <mailto:Lance.Andersen at oracle.com>