(XS) java.logging Level.java minor cleanups

[Bernd Eckenfels]

Hello Mandy,

the fields Level#name, Level#value and resourceBundleName accessed from KnownLevel inner class are private and therefore an synthetic accessor will be used. Eclipse warns about this.

But, Looking at it again, it is not only a non-issue with JEP 181 in Java 11, it is also hard to fix for 8u since the Level class is public and so the fields really should stay private. (I gues I was just suprised to see any synthetic accessors in Performance critical JCL classes)

Gruss
Bernd
-- 
http://bernd.eckenfels.net

Von: mandy chung
Gesendet: Donnerstag, 23. August 2018 22:02
An: Bernd Eckenfels; Daniel Fuchs
Cc: core-libs-dev at openjdk.java.net
Betreff: Re: (XS) java.logging Level.java minor cleanups



On 8/23/18 2:49 PM, Bernd Eckenfels wrote:
> 
> Did you had any opinion on the synthetic accessors as well?

:

>> BTW: I get a synthetic Accessor warning on l.name/value, is this
>> what  nestmates will resolve – is it worth adjusting the modifiers for>> 
those fields anyway?

What warning message did you get?

Mandy